Messages in this thread | | | Date | Wed, 04 Mar 2009 14:02:04 +0200 | From | Török Edwin <> | Subject | Re: [PATCH -v2] tracing: lockdep tracepoints |
| |
On 2009-03-04 13:32, Peter Zijlstra wrote: > On Wed, 2009-03-04 at 12:23 +0100, Frederic Weisbecker wrote: > >>> --- >>> Subject: tracing: lockdep tracepoints >>> From: Peter Zijlstra <a.p.zijlstra@chello.nl> >>> Date: Tue Mar 03 22:03:08 CET 2009 >>> >>> Augment the traces with lock names when lockdep is available: >>> >>> 1) | down_read_trylock() { >>> 1) | _spin_lock_irqsave() { >>> 1) | /* lock_acquire: name: &sem->wait_lock */ >>> 1) 4.201 us | } >>> 1) | _spin_unlock_irqrestore() { >>> 1) | /* lock_release: name: &sem->wait_lock */ >>> >> Nice idea. >> I would just suggest to drop the "name:" since the comment is intuitive enough >> to figure out what we have after lock_{release,acquire}: >> > > Makes sense I guess.. > > Here goes.. one s/name: //g later
Thanks for working on this. I just booted a kernel with your patch, and it worked.
When I find some time, I will try to write a locklatency tracer that uses these tracepoints.
Best regards, --Edwin
| |