Messages in this thread | | | Date | Tue, 31 Mar 2009 09:05:53 +0200 | Subject | Re: [PATCH] de: drivers/ide/ide-atapi.c needs <linux/scatterlist.h> | From | Geert Uytterhoeven <> |
| |
On Mon, Mar 30, 2009 at 22:29, Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote: > On Sunday 29 March 2009, Geert Uytterhoeven wrote: >> On m68k: >> | drivers/ide/ide-atapi.c: In function 'ide_io_buffers': >> | drivers/ide/ide-atapi.c:87: error: implicit declaration of function 'sg_page' >> | drivers/ide/ide-atapi.c:87: warning: passing argument 1 of 'PageHighMem' makes pointer from integer without a cast >> | drivers/ide/ide-atapi.c:91: warning: passing argument 1 of 'kmap_atomic' makes pointer from integer without a cast >> | drivers/ide/ide-atapi.c:96: error: implicit declaration of function 'sg_virt' >> | drivers/ide/ide-atapi.c:96: warning: assignment makes pointer from integer without a cast >> | drivers/ide/ide-atapi.c:107: error: implicit declaration of function 'sg_next' >> | drivers/ide/ide-atapi.c:107: warning: assignment makes pointer from integer without a cast >> >> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> > > thanks, applied > > [ Dmitri, sorry but m68k was faster than MIPS this time ;) ]
Thanks!
>> --- >> No idea where it got introduced. 2.6.29 was fine. > > Hmm... the issue went unnoticed because it was mitigated in linux-next > by ide_pio_bytes() conversion (resulting in ide_io_buffers() removal)...
I meant that I didn't see any removals of #include <linux/scatterlist.h> nor additions of sg_*() users since v2.6.29. But I did wonder why we never saw it in linux-next...
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |