Messages in this thread | | | Date | Wed, 1 Apr 2009 13:18:30 +1000 | Subject | Re: PAGE_CACHE_WC strikes again | From | Dave Airlie <> |
| |
On Wed, Apr 1, 2009 at 11:57 AM, Jesse Barnes <jbarnes@virtuousgeek.org> wrote: > On Tue, 31 Mar 2009 17:30:24 -0800 > Suresh Siddha <suresh.b.siddha@intel.com> wrote: > >> On Tue, 2009-03-31 at 18:12 -0700, Jesse Barnes wrote: >> > Right, the drm driver code went in before we had >> > pgprot_writecombine. Now that it's available we should definitely >> > use it. I'm not sure about the set_memory_* routines though; we >> > create io mappings in i915_dma.c at init time, and I thought we >> > took care of things in i915_gem.c but we may need updates there. >> >> Jesse, yes i915_gem.c seems to be doing the right thing. >> >> What about various fault handlers in drm_vm.c like >> drm_do_vm_shm_fault() etc. None of these fault handlers require >> special attributes like wc/uc etc? > > Those are legacy. I don't think they need anything changed... Dave > could correct me though.
Yeah just don't look at the top of drm_vm.c:drm_io_prot.
the attribute handling in there is one of the bits of the drm I hide away from.
and I think we can just move away from that with memory managed drivers doing it properly.
Dave. > > -- > Jesse Barnes, Intel Open Source Technology Center > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |