lkml.org 
[lkml]   [2009]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 00/05] tmio_mmc: Minor fixes and cnf/irq changes
Magnus Damm wrote:

> Ping? Please let me know how you want me to rework the patches. Unless
> they are ok as-is. Any feedback on how to rewrite them would be
> greatly appreciated.

I replied to this earlier. Basically, investigate using the clk API. You
should also try to work out how your board controls clock / power to
the socckets (if it can at all).

Like I said though, IIRC the clk API had shortcommings last time I
looked which made it impossible to use on MFD devices (its tied to the
CPU architecture, wheras the MFDs are platform independant. Dmitry did
some work on this, but I dont recall how far he got.

Let me know if you come up with answers / solutions to these probelms.
Until then, NAK - lets do it the right way, one time only. Not hack and
bodge it repeatedly.

Sorry if that seems harsh, but I dont have time to review a hack thats
going to end up replaced anyway when its done properly.

Best starting point would be to look up Dmitrys work on making the clk
api CPU agnostic (if that hasnt already been merged). Then tmio-mmc can
be modified to reqest a clock from its parent device (be that an MFD
core or a platform device or whatever).

-Ian

-Ian


\
 
 \ /
  Last update: 2009-03-31 20:41    [W:0.073 / U:1.992 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site