lkml.org 
[lkml]   [2009]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] dmaengine: fix regression introduced by d6103085dfd83c13db65c3bd7e182f021d77c541
    Guennadi Liakhovetski wrote:
    > chan is an index variable, used to loop over a list of channels, and here
    > it is used _after_ the loop, in which case it doesn't point to a DMA
    > channel struct anymore. Dereferencing it leads to a corruption of a random
    > memory location, which in my case was a pointer inside a clock struct. Fix
    > it by using a local variable pointing to the DMA device.
    >
    > Signed-off-by: Guennadi Liakhovetski <lg@denx.de>
    > ---
    >
    > Guys, this was a _real_ bad joke, cost me almost a day, and that patch has
    > been reviewed by two persons...
    >
    > <rant>
    > So far 2.6.29(-next) has been very bad for me, regressions all over the
    > place, lots of wasted time hunting them down:-(
    > </rant>
    >

    Guennadi,

    Thanks for testing the 'next' branch and finding this before it hit
    mainline. I will fold this change into the existing commit with a
    [lg@denx.de: fix bad usage of 'chan' in dma_async_device_register]

    Regards,
    Dan


    \
     
     \ /
      Last update: 2009-03-31 18:37    [W:0.020 / U:65.520 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site