Messages in this thread | | | Date | Tue, 31 Mar 2009 10:26:58 +0900 | From | Tejun Heo <> | Subject | Re: [PATCH 2/7] ext3: call blkdev_issue_flush() on fsync() |
| |
Hello,
Theodore Tso wrote: > On Mon, Mar 30, 2009 at 10:15:51AM -0400, Chris Mason wrote: >> I'm not sure we want to stick Fernando with changing how barriers are >> done in individual filesystems, his patch is just changing the existing >> call points. > > Well, his patch actually added some calls to block_issue_flush(). But > yes, it's probably better if he just changes the existing call points, > and we can have the relevant filesystem maintainers double check to > make sure that there aren't any new call points which are needed.
How about having something like blk_ensure_cache_flushed() which issues flush iff there hasn't been any write since the last flush? It'll be easy to implement and will filter out duplicate flushes in most cases.
Thanks.
-- tejun
| |