Messages in this thread | | | Subject | Re: [PATCH] make inotify event handles use GFP_NOFS | From | Peter Zijlstra <> | Date | Mon, 30 Mar 2009 23:33:36 +0200 |
| |
On Mon, 2009-03-30 at 14:26 -0700, Andrew Morton wrote: > On Wed, 18 Mar 2009 14:27:32 -0400 > Eric Paris <eparis@redhat.com> wrote: > > > I think this is a bandaide to shut up lockdep. I could either figure > > out lockdep classes and figure out how to reclassify inotify locks since > > I believe Nick is correct when he says inotify watches pin the inode in > > core so memory pressure can't evict it. > > It's pretty sad to degrading the strength of the memory allocation just > to squish a lockdep report.
Yeah, I agree, its the wrong thing to do. lockdep annotations really aren't that hard -- also, you could also talk me through it.
| |