Messages in this thread | | | Date | Mon, 30 Mar 2009 10:30:41 -0400 (EDT) | From | Christoph Lameter <> | Subject | Re: [patch 1/3] slub: add per-cache slab thrash ratio |
| |
On Sun, 29 Mar 2009, David Rientjes wrote:
> @@ -2291,10 +2292,13 @@ static int calculate_sizes(struct kmem_cache *s, int forced_order) > /* > * Determine the number of objects per slab > */ > + if (oo_objects(s->oo)) > + thrash_ratio = s->min_free_watermark * 100 / oo_objects(s->oo); > s->oo = oo_make(order, size);
s->oo is set *after* you check it. Check oo_objects after the value has been set please.
| |