[lkml]   [2009]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 2/2] Input: add wm97xx accelerated driver for AVR32 AT32AP700X microprocessors
On Tue, Mar 03, 2009 at 01:13:23AM -0800, Dmitry Torokhov wrote:
> Hi Mark,

This is actually Hans-Christian's patch but here goes...

> > + if (!pressure && source == WM97XX_ADCSEL_Y) {
> > + input_report_abs(wm->input_dev, ABS_X, at32_wm97xx->x);
> > + input_report_abs(wm->input_dev, ABS_Y, at32_wm97xx->y);
> > + input_report_abs(wm->input_dev, ABS_PRESSURE, pen_down);

> Please do not report pressure (and don't advertise ABS_PRESSURE) if you don't
> actually read it. I have seen a follow-up patch that adds BTN_TOUCH that should
> work just fine here. The usage below is good since there you actually do provide
> true pressure readings. BTW, why would one not want pressure readings?

These parts are usually deployed in embedded systems where performance
is sufficiently tightly constrained that the additional work involved in
taking pressure measurements is noticable. This is mostly the case
where PIO is used but users have reported problems even when using DMA
so idiomatically WM97xx drivers provide the option.

 \ /
  Last update: 2009-03-03 11:37    [W:0.063 / U:0.036 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site