lkml.org 
[lkml]   [2009]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 05/39] sata_nv: give up hardreset on nf2
Hello, Stefan.

Stefan Lippers-Hollmann wrote:
> Hi
>
> On Mittwoch, 18. Februar 2009, Greg KH wrote:
>> 2.6.28-stable review patch. If anyone has any objections, please let us know.
> [...]
>> From: Tejun Heo <tj@kernel.org>
>>
>> commit 7dac745b8e367c99175b8f0d014d996f0e5ed9e5 upstream.
>>
>> Kernel bz#12176 reports that nf2 hardreset simply doesn't work. Give
>> up. Argh...
>
> Sorry to report this rather late, but I upgraded a remote nforce3 system to
> 2.6.28.7 today, and noticed the following messages repeating continously
> (reproducable on a different nforce3 system as well):
>
> ata4: EH pending after 5 tries, giving up
> ata4: EH complete
> ata4: EH pending after 5 tries, giving up
> ata4: EH complete
>
> Reverting just this patch from 2.6.28.7 lets them disappear again. Likewise
> 2.6.29-rc6-git7 is affected as well - and reverting this patch seems to fix
> the issue there as well.

This is reported in bko#11615. I don't quite understand it yet. The
only thing that should have changed is the use of softreset instead of
hardreset and changing inheritance to nv_generic_ops should have done
exactly that in a very safe way. Apparently, it didn't. I'll dig
into what went wrong.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2009-03-04 03:15    [W:0.079 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site