Messages in this thread | | | Date | Wed, 4 Mar 2009 09:29:20 +0900 | From | KAMEZAWA Hiroyuki <> | Subject | Re: + cgroup-allow-subsys-to-set-default-mode-of-its-own-file.patch added to -mm tree |
| |
On Tue, 3 Mar 2009 08:59:00 +0100 Ingo Molnar <mingo@elte.hu> wrote:
> > * akpm@linux-foundation.org <akpm@linux-foundation.org> wrote: > > > + int mode = 0644; > > + if (cft->mode) > > + mode = cft->mode; > > ditto... > Maybe Li Zefan's one "cgroups-show-correct-file-mode.patch" is now in -mm. and this patch is dropped. And it has the same problem...
Li-san, could you rewrite this part of your patch == + if (cft->read || cft->read_u64 || cft->read_s64 || + cft->read_map || cft->read_seq_string) + mode |= 0444; + + if (cft->write || cft->write_u64 || cft->write_s64 || + cft->write_string || cft->trigger) + mode |= 0200; + == with macro as S_IRUSR etc... ?
Thanks, -Kame
| |