lkml.org 
[lkml]   [2009]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: + cgroup-allow-subsys-to-set-default-mode-of-its-own-file.patch added to -mm tree
On Tue, 3 Mar 2009 08:59:00 +0100
Ingo Molnar <mingo@elte.hu> wrote:

>
> * akpm@linux-foundation.org <akpm@linux-foundation.org> wrote:
>
> > + int mode = 0644;
> > + if (cft->mode)
> > + mode = cft->mode;
>
> ditto...
>
Maybe Li Zefan's one "cgroups-show-correct-file-mode.patch" is now in -mm.
and this patch is dropped. And it has the same problem...

Li-san, could you rewrite this part of your patch
==
+ if (cft->read || cft->read_u64 || cft->read_s64 ||
+ cft->read_map || cft->read_seq_string)
+ mode |= 0444;
+
+ if (cft->write || cft->write_u64 || cft->write_s64 ||
+ cft->write_string || cft->trigger)
+ mode |= 0200;
+
==
with macro as S_IRUSR etc... ?

Thanks,
-Kame



\
 
 \ /
  Last update: 2009-03-04 01:33    [W:1.262 / U:0.252 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site