lkml.org 
[lkml]   [2009]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: + cgroup-memcg-show-correct-file-mode.patch added to -mm tree
On Tue, 3 Mar 2009 08:58:28 +0100
Ingo Molnar <mingo@elte.hu> wrote:

>
> * akpm@linux-foundation.org <akpm@linux-foundation.org> wrote:
>
> > .name = "usage_in_bytes",
> > .private = MEMFILE_PRIVATE(_MEM, RES_USAGE),
> > .read_u64 = mem_cgroup_read,
> > + .mode = 0444
>
> Uhm, we've got symbols for permission bits for a reason.
> (S_IRUGO in this case)
>
> > + .mode = 0444
>
> Ditto.
>
> > + .mode = 0200
>
> Ditto. (S_IWUSR)
>
> > + .mode = 0444
>
> Ditto.
>
ok, will post a replacement.

Thank you for pointing out.
-Kame

> Ingo
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>



\
 
 \ /
  Last update: 2009-03-04 01:31    [W:0.035 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site