lkml.org 
[lkml]   [2009]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] binfmt_flat: fix data sections alignment
On Tue, Mar 03, 2009 at 05:33:13PM +0100, Johannes Weiner wrote:
> The flat loader uses an architecture's flat_stack_align() to align the
> stack but assumes word-alignment is enough for the data sections.
>
> However, on the Xtensa S6000 we need an alignment of more than
> wordsize for data that is loaded to 128bit wide registers.
>
> This patch replaces the specific flat_stack_align() with a more
> generic flat_data_align() that is then used for both stack, the data
> and bss section.
>
> It also fixes m32r which was obviously kaput, aligning an
> uninitialized stack entry instead of the stack pointer.
>
Can you provide a bit more information about this for your platform? I
note that while this patch is aimed to generalize things for your
platform, there is no Xtensa patch included here, making it difficult to
Ack without having more context to go on.

Based on your description, it looks like you need register size alignment
in the case where your registers are greater than BYTES_PER_WORD, or the
pointer size. If this is the case, then you are going to have the same
issues with the slab caches and need to set ARCH_SLAB_MINALIGN
accordingly. This is presently a situation that exists for certain ARM
and SH platforms already today, but none that are actively used in nommu
configurations. It would be preferable to generalize this, rather than
duplicating the special-cased alignment.


\
 
 \ /
  Last update: 2009-03-03 19:35    [from the cache]
©2003-2011 Jasper Spaans