lkml.org 
[lkml]   [2009]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH] hppfs: hppfs_read_file() may return -ERROR
FYI: hppfs_read_file() is at: vi fs/hppfs/hppfs.c +212
------------------------------>8-------------8<---------------------------------
hppfs_read_file() may return (ssize_t) -ENOMEM, or -EFAULT. when stored in
size_t 'count', these errors will not be noticed, a large value will be added to
*ppos.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
---
diff --git a/fs/hppfs/hppfs.c b/fs/hppfs/hppfs.c
index b278f7f..a5089a6 100644
--- a/fs/hppfs/hppfs.c
+++ b/fs/hppfs/hppfs.c
@@ -280,7 +280,12 @@ static ssize_t hppfs_read(struct file *file, char __user *buf, size_t count,
"errno = %d\n", err);
return err;
}
- count = hppfs_read_file(hppfs->host_fd, buf, count);
+ err = hppfs_read_file(hppfs->host_fd, buf, count);
+ if (err < 0) {
+ printk(KERN_ERR "hppfs_read: read failed: %d\n", err);
+ return err;
+ }
+ count = err;
if (count > 0)
*ppos += count;
}

\
 
 \ /
  Last update: 2009-03-03 16:43    [W:0.028 / U:0.260 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site