lkml.org 
[lkml]   [2009]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2 2/3] sched: Fix the wakeup nomination for sched_mc/smt_power_savings.

    * Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:

    > On Tue, 2009-03-03 at 17:21 +0530, Gautham R Shenoy wrote:
    > > +/* Assign the sched-domain level which can nominate preferred wake-up cpu */
    > > + rd->sched_mc_preferred_wakeup_cpu = UINT_MAX;
    > > + rd->authorized_nomination_level = SD_LV_NONE;
    > > +
    > > + if (active_power_savings_level >= POWERSAVINGS_BALANCE_WAKEUP) {
    > > + struct sched_domain *sd;
    > > + enum sched_domain_level authorized_nomination_level =
    > > + SD_LV_NONE;
    > > +
    > > + for_each_domain(first_cpu(*cpu_map), sd) {
    > > + if (!(sd->flags & SD_POWERSAVINGS_BALANCE))
    > > + continue;
    > > + authorized_nomination_level = sd->level;
    > > + }
    > > +
    > > + rd->authorized_nomination_level = authorized_nomination_level;
    > > + }
    >
    > Very odd looking comments there, and that enum init wrapping looks
    > weird. Either exceed 80 chars, or write it in a second line like:
    >
    > enum sched_domain_level authorized_nomination_level;
    >
    > authorized_nomination_level = SD_LV_NONE;

    I think find_busiest_group() needs to be split up into several
    helper functions first, before we add more to it. I.e. first a
    couple of cleanup patches that factor it out into 3-4 helper
    functions plus a really easy-to-read find_busiest_group() main
    function.

    Then can we do the above change - and i bet we'll win at least
    one indentation level as well so that weird line break goes
    away.

    Ingo


    \
     
     \ /
      Last update: 2009-03-03 15:01    [W:5.481 / U:1.396 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site