lkml.org 
[lkml]   [2009]   [Mar]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2 2/3] sched: Fix the wakeup nomination for sched_mc/smt_power_savings.
From
Date
On Tue, 2009-03-03 at 17:21 +0530, Gautham R Shenoy wrote:
> +/* Assign the sched-domain level which can nominate preferred wake-up cpu */
> + rd->sched_mc_preferred_wakeup_cpu = UINT_MAX;
> + rd->authorized_nomination_level = SD_LV_NONE;
> +
> + if (active_power_savings_level >= POWERSAVINGS_BALANCE_WAKEUP) {
> + struct sched_domain *sd;
> + enum sched_domain_level authorized_nomination_level =
> + SD_LV_NONE;
> +
> + for_each_domain(first_cpu(*cpu_map), sd) {
> + if (!(sd->flags & SD_POWERSAVINGS_BALANCE))
> + continue;
> + authorized_nomination_level = sd->level;
> + }
> +
> + rd->authorized_nomination_level = authorized_nomination_level;
> + }

Very odd looking comments there, and that enum init wrapping looks
weird. Either exceed 80 chars, or write it in a second line like:

enum sched_domain_level authorized_nomination_level;

authorized_nomination_level = SD_LV_NONE;



\
 
 \ /
  Last update: 2009-03-03 13:27    [W:0.461 / U:0.132 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site