lkml.org 
[lkml]   [2009]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] move jazzsonic's probe function to .devinit.text
    From
    2009/3/28 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:
    > A pointer to jazz_sonic_probe is passed to the core via
    > platform_driver_register and so the function must not disappear when the
    > .init sections are discarded.  Otherwise (if also having HOTPLUG=y)
    > unbinding and binding a device to the driver via sysfs will result in an
    > oops as does a device being registered late.
    >
    > As noticed by Geert Uytterhoeven sonic_probe1 is called by
    > jazz_sonic_probe, so the former has to move to .devinit.text, too.
    >
    > An alternative to this patch is using platform_driver_probe instead of
    > platform_driver_register plus removing the pointer to the probe function
    > from the struct platform_driver.
    >
    > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    > Cc: Ralf Baechle <ralf@linux-mips.org>
    > Cc: Jeff Garzik <jeff@garzik.org>
    > Cc: David S. Miller <davem@davemloft.net>
    > Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
    > Cc: Finn Thain <fthain@telegraphics.com.au>
    > Cc: Geert Uytterhoeven <geert@linux-m68k.org>
    > Cc: Andrew Morton <akpm@linux-foundation.org>
    > ---
    > Hi Geert and Ralf,
    >
    > thanks for your feed-back.
    >
    > @Geert: Did you notice this, or your compiler?

    I noticed this in macsonic, when I reviewed your patch.
    As jazzsonic is very similar to macsonic, I suspected your patch had the
    same issue there ;-)

    Probably the compiler didn't tell you, because it inlined the other functions.
    Still wondering why my compiler didn't tell me before. Maybe I just forgot to
    build for Mac with CONFIG_DEBUG_SECTION_MISMATCH=y...

    Gr{oetje,eeting}s,

    Geert

    --
    Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

    In personal conversations with technical people, I call myself a hacker. But
    when I'm talking to journalists I just say "programmer" or something like that.
    -- Linus Torvalds
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-03-29 10:59    [W:0.023 / U:0.108 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site