lkml.org 
[lkml]   [2009]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/3] PCI: allow PCI core hotplug to remove PCI root bus
    Alex Chiang wrote:
    > There is no reason to prevent root bus removal. We never actually
    > remove the node from the pci_root_buses list, so a rescan will correctly
    > rediscover the root bus.
    >

    I'm a little confused about the description. I don't think the
    patch is for allowing pci root bus removal. I think it is for
    allowing removal of pci devices on pci root buses.

    Thanks,
    Kenji Kaneshige


    > Signed-off-by: Alex Chiang <achiang@hp.com>
    > ---
    >
    > drivers/pci/pci-sysfs.c | 4 ----
    > 1 files changed, 0 insertions(+), 4 deletions(-)
    >
    > diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c
    > index e9a8706..7b2cb27 100644
    > --- a/drivers/pci/pci-sysfs.c
    > +++ b/drivers/pci/pci-sysfs.c
    > @@ -277,14 +277,10 @@ remove_store(struct device *dev, struct device_attribute *dummy,
    > {
    > int ret = 0;
    > unsigned long val;
    > - struct pci_dev *pdev = to_pci_dev(dev);
    >
    > if (strict_strtoul(buf, 0, &val) < 0)
    > return -EINVAL;
    >
    > - if (pci_is_root_bus(pdev->bus))
    > - return -EBUSY;
    > -
    > /* An attribute cannot be unregistered by one of its own methods,
    > * so we have to use this roundabout approach.
    > */
    >
    > --
    > To unsubscribe from this list: send the line "unsubscribe linux-pci" in
    > the body of a message to majordomo@vger.kernel.org
    > More majordomo info at http://vger.kernel.org/majordomo-info.html
    >
    >




    \
     
     \ /
      Last update: 2009-03-30 04:17    [W:0.024 / U:32.692 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site