Messages in this thread | | | Date | Sat, 28 Mar 2009 10:26:22 +0100 | From | Kristoffer Ericson <> | Subject | Re: [PATCH 23/58] move jornada_ssp's probe function to .devinit.text |
| |
Acked-by : Kristoffer Ericson <kristoffer.ericson@gmail.com>
Thx
On Sat, 28 Mar 2009 00:26:44 +0100 Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> A pointer to jornada_ssp_probe is passed to the core via > platform_driver_register and so the function must not disappear when the > .init sections are discarded. Otherwise (if also having HOTPLUG=y) > unbinding and binding a device to the driver via sysfs will result in an > oops as does a device being registered late. > > An alternative to this patch is using platform_driver_probe instead of > platform_driver_register plus removing the pointer to the probe function > from the struct platform_driver. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > Cc: Kristoffer Ericson <Kristoffer.Ericson@gmail.com> > Cc: Russell King <rmk+kernel@arm.linux.org.uk> > Cc: Andrew Morton <akpm@linux-foundation.org> > --- > arch/arm/mach-sa1100/jornada720_ssp.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/mach-sa1100/jornada720_ssp.c b/arch/arm/mach-sa1100/jornada720_ssp.c > index 28cf369..ce4c6cb 100644 > --- a/arch/arm/mach-sa1100/jornada720_ssp.c > +++ b/arch/arm/mach-sa1100/jornada720_ssp.c > @@ -130,7 +130,7 @@ void jornada_ssp_end(void) > }; > EXPORT_SYMBOL(jornada_ssp_end); > > -static int __init jornada_ssp_probe(struct platform_device *dev) > +static int __devinit jornada_ssp_probe(struct platform_device *dev) > { > int ret; > > -- > 1.6.2 >
-- Kristoffer Ericson <kristoffer.ericson@gmail.com> [unhandled content-type:application/pgp-signature]
| |