Messages in this thread | | | Date | Sun, 29 Mar 2009 09:23:46 +0800 | Subject | Re: [PATCH 47/58] move sharpsl-pm's probe function to .devinit.text | From | Eric Miao <> |
| |
2009/3/29 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>: > On Sat, Mar 28, 2009 at 05:32:02PM +0800, Eric Miao wrote: >> 2009/3/28 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>: >> > A pointer to sharpsl_pm_probe is passed to the core via >> > platform_driver_register and so the function must not disappear when the >> > .init sections are discarded. Otherwise (if also having HOTPLUG=y) >> > unbinding and binding a device to the driver via sysfs will result in an >> > oops as does a device being registered late. >> > >> > An alternative to this patch is using platform_driver_probe instead of >> > platform_driver_register plus removing the pointer to the probe function >> > from the struct platform_driver. >> > >> >> This one looks OK to me. > I assume this is an Acked-by: you? >
Acked-by: Eric Miao <eric.miao@marvell.com>
> Best regards > Uwe > > -- > Pengutronix e.K. | Uwe Kleine-König | > Industrial Linux Solutions | http://www.pengutronix.de/ | >
-- Cheers - eric -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |