lkml.org 
[lkml]   [2009]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 43/58] move sb1250-mac's probe function to .devinit.text
    Date
    A pointer to sbmac_probe is passed to the core via
    platform_driver_register and so the function must not disappear when the
    .init sections are discarded. Otherwise (if also having HOTPLUG=y)
    unbinding and binding a device to the driver via sysfs will result in an
    oops as does a device being registered late.

    An alternative to this patch is using platform_driver_probe instead of
    platform_driver_register plus removing the pointer to the probe function
    from the struct platform_driver.

    Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    Cc: Weiwei Wang <weiwei.wang@windriver.com>
    Cc: Jeff Garzik <jgarzik@redhat.com>
    Cc: David S. Miller <davem@davemloft.net>
    Cc: Stephen Hemminger <shemminger@vyatta.com>
    Cc: Maciej W. Rozycki <macro@linux-mips.org>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    ---
    drivers/net/sb1250-mac.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/net/sb1250-mac.c b/drivers/net/sb1250-mac.c
    index 88dd2e0..8c961b9 100644
    --- a/drivers/net/sb1250-mac.c
    +++ b/drivers/net/sb1250-mac.c
    @@ -2683,7 +2683,7 @@ static int sbmac_poll(struct napi_struct *napi, int budget)
    }


    -static int __init sbmac_probe(struct platform_device *pldev)
    +static int __devinit sbmac_probe(struct platform_device *pldev)
    {
    struct net_device *dev;
    struct sbmac_softc *sc;
    --
    1.6.2
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-03-28 00:51    [W:0.022 / U:17.964 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site