Messages in this thread Patch in this message | | | From | Uwe Kleine-König <> | Subject | [PATCH 15/58] move gbefb's probe function to .devinit.text | Date | Sat, 28 Mar 2009 00:26:36 +0100 |
| |
A pointer to gbefb_probe is passed to the core via platform_driver_register and so the function must not disappear when the .init sections are discarded. Otherwise (if also having HOTPLUG=y) unbinding and binding a device to the driver via sysfs will result in an oops as does a device being registered late.
An alternative to this patch is using platform_driver_probe instead of platform_driver_register plus removing the pointer to the probe function from the struct platform_driver.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Cc: Roel Kluin <roel.kluin@gmail.com> Cc: Krzysztof Helt <krzysztof.h1@poczta.fm> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Antonino Daplas <adaplas@pol.net> Cc: Kaj-Michael Lang <milang@tal.org> Cc: Martin Michlmayr <tbm@cyrius.com> Cc: Joshua Kinard <kumba@gentoo.org> --- drivers/video/gbefb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/gbefb.c b/drivers/video/gbefb.c index fe5b519..4c7f3a0 100644 --- a/drivers/video/gbefb.c +++ b/drivers/video/gbefb.c @@ -1128,7 +1128,7 @@ int __init gbefb_setup(char *options) return 0; } -static int __init gbefb_probe(struct platform_device *p_dev) +static int __devinit gbefb_probe(struct platform_device *p_dev) { int i, ret = 0; struct fb_info *info; -- 1.6.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |