lkml.org 
[lkml]   [2009]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 05/58] move at91_wdt's probe function to .devinit.text
    Date
    A pointer to at91wdt_probe is passed to the core via
    platform_driver_register and so the function must not disappear when the
    .init sections are discarded. Otherwise (if also having HOTPLUG=y)
    unbinding and binding a device to the driver via sysfs will result in an
    oops as does a device being registered late.

    An alternative to this patch is using platform_driver_probe instead of
    platform_driver_register plus removing the pointer to the probe function
    from the struct platform_driver.

    Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    Cc: Andrew Victor <linux@maxim.org.za>
    Cc: Russell King <rmk+kernel@arm.linux.org.uk>
    Cc: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
    Cc: Ilpo Jarvinen <ilpo.jarvinen@helsinki.fi>
    Cc: Wim Van Sebroeck <wim@iguana.be>
    Cc: Andrew Morton <akpm@linux-foundation.org>
    ---
    drivers/watchdog/at91rm9200_wdt.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/watchdog/at91rm9200_wdt.c b/drivers/watchdog/at91rm9200_wdt.c
    index e35d545..ee82323 100644
    --- a/drivers/watchdog/at91rm9200_wdt.c
    +++ b/drivers/watchdog/at91rm9200_wdt.c
    @@ -197,7 +197,7 @@ static struct miscdevice at91wdt_miscdev = {
    .fops = &at91wdt_fops,
    };

    -static int __init at91wdt_probe(struct platform_device *pdev)
    +static int __devinit at91wdt_probe(struct platform_device *pdev)
    {
    int res;

    --
    1.6.2
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2009-03-28 00:35    [W:0.026 / U:149.912 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site