Messages in this thread | | | From | Hans Verkuil <> | Subject | Re: [PATCH] v4l2: fill reserved fields of VIDIOC_ENUMAUDIO also | Date | Fri, 27 Mar 2009 21:34:07 +0100 |
| |
On Friday 27 March 2009 20:45:40 Trent Piepho wrote: > On Fri, 27 Mar 2009, Mauro Carvalho Chehab wrote: > > On Wed, 25 Mar 2009 17:51:39 +0100 > > > > Németh Márton <nm127@freemail.hu> wrote: > > > From: Márton Németh <nm127@freemail.hu> > > > > > > When enumerating audio inputs with VIDIOC_ENUMAUDIO the gspca_sunplus > > > driver does not fill the reserved fields of the struct v4l2_audio > > > with zeros as required by V4L2 API revision 0.24 [1]. Add the missing > > > initializations to the V4L2 framework. > > > > > > The patch was tested with v4l-test 0.10 [2] with gspca_sunplus driver > > > and with Trust 610 LCD POWERC@M ZOOM webcam. > > > > It didn't apply against the development tree. Anyway, a recent patch > > removed the need of memset there. the memory fill with zero now happens > > at the same code we copy the structure values. > > That code is in video_ioctl2, which gspca doesn't use.
Yes, gspca does use video_ioctl2. You're probably confused with uvcvideo, which doesn't use it.
Regards,
Hans
-- Hans Verkuil - video4linux developer - sponsored by TANDBERG -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |