Messages in this thread | | | Subject | Re: [PATCH] btrfs: fix __ucmpdi2 compile bug on 32 bit builds | From | Chris Mason <> | Date | Fri, 27 Mar 2009 10:37:44 -0400 |
| |
On Fri, 2009-03-27 at 10:24 -0400, Kyle McMartin wrote: > On Sat, Mar 28, 2009 at 01:16:26AM +1100, Stephen Rothwell wrote: > > > - switch (em->block_start) { > > > - case EXTENT_MAP_LAST_BYTE: > > > + if (em->block_start == EXTENT_MAP_LAST_BYTE) { > > > > I might be a good idea to put a comment there about why this isn't a > > switch statement so that someone doesn't "clean up" this code in the > > future. > > > > nrrrgh. Remind me why we can't just add the libgcc helpers? > > Unless we plan on growing some more of these, surely we can just reduce > it to a u32 for the switch...
EXTENT_MAP_LAST_BYTE is something like (u64)-5
This if/else setup is fine, I'll take the patch.
-chris
| |