lkml.org 
[lkml]   [2009]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] Fix wrong format string iter for printk
On Fri, Mar 27, 2009 at 05:09:10PM +0800, Zhaolei wrote:
> printk("%Q");
> Output before patch:
> %QQ
> Output after patch:
> %Q
>
> Signed-off-by: Zhao Lei <zhaolei@cn.fujitsu.com>
> ---
> lib/vsprintf.c | 16 ----------------
> 1 files changed, 0 insertions(+), 16 deletions(-)
>
> diff --git a/lib/vsprintf.c b/lib/vsprintf.c
> index 908dd41..b56f6d0 100644
> --- a/lib/vsprintf.c
> +++ b/lib/vsprintf.c
> @@ -1062,13 +1062,6 @@ int vsnprintf(char *buf, size_t size, const char *fmt, va_list args)
> if (str < end)
> *str = '%';
> ++str;
> - if (*fmt) {
> - if (str < end)
> - *str = *fmt;
> - ++str;
> - } else {
> - --fmt;
> - }
> break;
>
> case FORMAT_TYPE_NRCHARS: {
> @@ -1356,8 +1349,6 @@ do { \
> break;
>
> case FORMAT_TYPE_INVALID:
> - if (!*fmt)
> - --fmt;
> break;
>
> case FORMAT_TYPE_NRCHARS: {
> @@ -1544,13 +1535,6 @@ int bstr_printf(char *buf, size_t size, const char *fmt, const u32 *bin_buf)
> if (str < end)
> *str = '%';
> ++str;
> - if (*fmt) {
> - if (str < end)
> - *str = *fmt;
> - ++str;
> - } else {
> - --fmt;
> - }
> break;
>
> case FORMAT_TYPE_NRCHARS:
> --
> 1.5.5.3
>
>


Thanks for fixing this!



\
 
 \ /
  Last update: 2009-03-27 13:57    [W:0.074 / U:0.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site