lkml.org 
[lkml]   [2009]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 03/14] block: implement blk_rq_map_kern_prealloc()
    On 03/26/2009 10:05 AM, Boaz Harrosh wrote:
    > On 03/26/2009 09:42 AM, Tejun Heo wrote:
    >> The thing is that the prealloc variant should be allowed to be called
    >> from IRQ context and blk_queue_bounce() shouldn't be called.
    >> Hmmm... well, the caller is supposed to know what it's doing and maybe
    >> we can just add a comment that it shouldn't be called with buffers
    >> which might get bounced from IRQ context.
    >>
    >
    > Hmm that is a problem. I would suggest a flag or a check. My bios come
    > from VFS they need bouncing.
    >
    > Can you think of a solution?
    >
    > We could just call blk_queue_bounce(). IRQ callers need to make sure their
    > buffers don't need bouncing anyway, so there is no such bug right? If a programmer
    > gets it wrong he will get a BUG check that tells him that.
    >

    I just realized that in your original call you had the "force" flag, we can keep
    that flag for the blk_rq_set_bio(), or what ever we should name it.

    Thanks
    Boaz


    \
     
     \ /
      Last update: 2009-03-26 09:15    [W:0.023 / U:1.288 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site