Messages in this thread | | | Date | Thu, 26 Mar 2009 16:41:15 -0700 (PDT) | From | Linus Torvalds <> | Subject | Re: RDMA/nes: Fix mis-merge |
| |
On Thu, 26 Mar 2009, Linus Torvalds wrote:
> > > On Thu, 26 Mar 2009, David Miller wrote: > > > > Acked-by: David S. Miller <davem@davemloft.net> > > Can I get a sign-off from Roland too?
Btw, as far as I can tell, that function had never been tested with any polling. It had a line like
netif_napi_add(netdev, &nesvnic->napi, nes_netdev_poll, 128);
but that line was _before_ 'nesvnic' was actually initialized (well, it had been initialized to NULL, so it passed in some NULL-pointer-offset to that function).
I moved that initialization up in the merge, but I obviously didn't test anything. So I'd suggest somebody actually test this case, because it clearly must have gotten no testing at all.
Linus
| |