lkml.org 
[lkml]   [2009]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: USB: symbolserial: log the ioctl commands

> +static int symbol_tiocmget(struct tty_struct *tty, struct file *file)
> +{
> + struct usb_serial_port *port = tty->driver_data;
> + struct device *dev = &port->dev;
> +
> + /* TODO */
> + /* probably just need to shadow whatever was sent to us here */
> + dev_info(dev, "%s\n", __func__);
> + return 0;
> +}

If you don't have a modem you don't provide these methods. If you do have
a modem you return the values for the modem. Please do not try and stick
in stuff faking responses, it just makes a nasty mess in the longer term
and I've already cleared the same out of a ton of drivers - with I note
no breakages of user space.



\
 
 \ /
  Last update: 2009-03-26 20:47    [W:0.031 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site