lkml.org 
[lkml]   [2009]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] ftrace: advance readpos in trace_seq_to_user() by really read bytes
On Thu, 26 Mar 2009 18:22:18 +0100
Vitaly Mayatskikh <v.mayatskih@gmail.com> wrote:

> If tracer will not provide input buffer of enough size, he will never
> see data between cnt and len bytes.
>
> diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> index 17bb88d..0217615 100644
> --- a/kernel/trace/trace.c
> +++ b/kernel/trace/trace.c
> @@ -477,7 +477,7 @@ ssize_t trace_seq_to_user(struct trace_seq *s, char __user *ubuf, size_t cnt)
> if (ret)
> return -EFAULT;
>
> - s->readpos += len;
> + s->readpos += cnt;
> return cnt;
> }

This fix seems to be already included in tip/master:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git

It's not in Linus' master, but I guess it's on its way there.

Thanks.

--
Pekka Paalanen
http://www.iki.fi/pq/


\
 
 \ /
  Last update: 2009-03-26 19:17    [W:0.043 / U:0.788 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site