Messages in this thread | | | Date | Wed, 25 Mar 2009 08:50:44 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [PATCH 2/5] mm: remove unlikly NULL from kfree |
| |
On Wed, 25 Mar 2009, Pekka Enberg wrote: > On Wed, Mar 25, 2009 at 7:19 AM, Steven Rostedt <rostedt@goodmis.org> wrote: > > This makes sense, since we now encourage developers to just call kfree > > without checking for NULL. > > But those are _error handling paths_ (at least supposed to be). I > wonder which call-sites are responsible for this. Can frtrace help us > here?
Why is this an error handler. We replaced tons of
if (obj) kfree(obj);
constructs all over the kernel with kfree(obj); and let kfree deal with the NULL pointer.
Thanks,
tglx
| |