Messages in this thread | | | Date | Thu, 26 Mar 2009 00:36:11 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [PATCH] x86: don't compile vsmp_64 for 32bit |
| |
On Wed, 25 Mar 2009, Ravikiran G Thirumalai wrote: > > Sure, but it would be cleaner if the whole file were controlled by > > CONFIG_X86_VSMP. is_vsmp_box() is already defined as const inline > > returning 0 if !CONFIG_X86_VSMP. > > > > The point in this thread was, is_vsmp_box() needs to be meaningful even when > CONFIG_X86_VSMP is not on. This is needed because is_vsmp_box() is used to > determine if the platform has reliable tscs.
Did you even read what Jeremy wrote or bother to look at the code in arch/x86/include/asm/apic.h ?
#ifdef CONFIG_X86_VSMP extern int is_vsmp_box(void); #else static inline int is_vsmp_box(void) { return 0; } #endif
So the .c file is completely useless if CONFIG_X86_VSMP=n.
Thanks,
tglx
| |