Messages in this thread | | | Subject | Re: [PATCH] writeback: reset inode dirty time when adding it back to empty s_dirty list | From | Chris Mason <> | Date | Wed, 25 Mar 2009 16:07:02 -0400 |
| |
On Wed, 2009-03-25 at 12:55 -0400, hch@infradead.org wrote: > On Wed, Mar 25, 2009 at 08:17:43PM +0800, Wu Fengguang wrote: > > Now there are now two possible solutions: > > - unconditionally update dirtied_when in redirty_tail(); > > - keep dirtied_when and redirty inodes to a new dedicated queue. > > The first one involves less code, the second one allows more flexible timing. > > > > NFS/XFS could be a good starting point for discussing the > > requirements, so that we can reach a suitable solution. > > Note that the XFS requirement also applies to all filesystems that > perform some sort of metadata updats on I/O completeion. That includes > at least ext4, btrfs and most likely the cluster filesystems too.
btrfs at least doesn't dirty the inode on I/O completion. It just puts the changes directly into the btree blocks.
-chris
| |