Messages in this thread | | | Date | Wed, 25 Mar 2009 21:05:37 +0100 | Subject | Re: [PATCH] module: Kill warning: label 'free_init' defined but not used | From | Geert Uytterhoeven <> |
| |
On Wed, Mar 25, 2009 at 20:54, Jaswinder Singh Rajput <jaswinder@kernel.org> wrote: > On Wed, 2009-03-25 at 20:43 +0100, Geert Uytterhoeven wrote: >> On m68k (which doesn't do SMP), I get: >> >> | kernel/module.c:2291: warning: label 'free_init' defined but not used >> >> which was introduced by commit 6e2b75740bed35df98b8113300579e13ed2ce848 >> ("module: fix refptr allocation and release order"). >> Move the label inside the #ifdef, as the goto is protected by the same #ifdef. >> >> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org> >> --- > > AFAIK, it is already fixed in -tip: > http://git.kernel.org/?p=linux/kernel/git/x86/linux-2.6-tip.git;a=commit;h=67f5ca081c6ace125e8ccc76b8a7d99b091abaa7
Interesting, as I noticed the problem in today's linux-next. http://kisskb.ellerman.id.au/kisskb/buildresult/271602/ Or am I caught again by fake warnings from the bisection process?
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |