lkml.org 
[lkml]   [2009]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/5][RFC] tracing: add function profiler

    On Wed, 25 Mar 2009, Frederic Weisbecker wrote:
    > > +
    > > +static const struct file_operations ftrace_profile_fops = {
    > > + .open = tracing_open_generic,
    > > + .read = ftrace_profile_read,
    > > + .write = ftrace_profile_write,
    > > +};
    >
    >
    > I should really provide such helper per stat tracer.
    >
    > Say, something like:
    >
    > /debug/tracing/trace_stat/name/enable
    >

    No, because if you notice in the later patches, I add a per cpu tracing.
    This is standard operations, and adding too much will unnecessarily limit
    what we can do.

    -- Steve



    \
     
     \ /
      Last update: 2009-03-25 20:35    [W:0.020 / U:29.224 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site