lkml.org 
[lkml]   [2009]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mmc: align data size for host which only supports power-of-2 block
On Wed, 25 Mar 2009 11:22:25 +0800
"Cai, Cliff" <Cliff.Cai@analog.com> wrote:

> >
> >This patch seems premature as there is no associated
> >modification of any of the host drivers.
>
> The SDH on Blackfin BF54x/BF51x only supports power-of-2 block
> transfer,we will soon
> Send the sdh driver to mainline as well.
>

Ok. Looking forward to it. :)

> >Padding to a power of two size can also mean a rather large
> >padding. We might need to check the host data limits after
> >doing the adjustment.
>
> Yes,but it's the higher level driver's job.
>

mmc_align_data_size() shouldn't be adjusting the size to something it
can easily determine that it's invalid.

Rgds
--
-- Pierre Ossman

Linux kernel, MMC maintainer http://www.kernel.org
rdesktop, core developer http://www.rdesktop.org

WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end
encryption.


\
 
 \ /
  Last update: 2009-03-25 20:27    [from the cache]
©2003-2011 Jasper Spaans