lkml.org 
[lkml]   [2009]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] reiserfs: select CRC32 and BITREVERSE for REISERFS_FS Kconfig entry
Coly Li wrote:
> In patch fs-reiserfs-return-f_fsid-for-statfs2-v2.patch (from mmotm), crc32_le()
> is referenced. If reiserfs is compiled into kernel and crc32_le() is compiled as
> kernel module, there might be a compiling error as:
> fs/built-in.o: In function `reiserfs_statfs':
> super.c:(.text+0x7332b): undefined reference to `crc32_le'
> super.c:(.text+0x7333f): undefined reference to `crc32_le'
> This patch select CRC32 and BITREVERSE for REISERFS_FS Kconfig entry, which
> indicates compiling crc32_le() into kernel.
>
> Thanks to Randy Dunlap for pointing out this error and providing helpful solution.
>
> Signed-off-by: Coly Li <coly.li@suse.de>
> Cc: Randy Dunlap <randy.dunlap@oracle.com>

Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
Tested-by: Randy Dunlap <randy.dunlap@oracle.com>

Thanks.

> Cc: Andrew Morton <akpm@linux-foundation.org>
> ---
> fs/reiserfs/Kconfig | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/fs/reiserfs/Kconfig b/fs/reiserfs/Kconfig
> index 949b8c6..9712bea 100644
> --- a/fs/reiserfs/Kconfig
> +++ b/fs/reiserfs/Kconfig
> @@ -1,5 +1,7 @@
> config REISERFS_FS
> tristate "Reiserfs support"
> + select CRC32
> + select BITREVERSE
> help
> Stores not just filenames but the files themselves in a balanced
> tree. Uses journalling.


--
~Randy


\
 
 \ /
  Last update: 2009-03-25 18:13    [W:0.040 / U:0.816 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site