lkml.org 
[lkml]   [2009]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [tip:sched/balancing] sched: Add comments to find_busiest_group() function
From
This commit says it's just adding comments, but...

On Wed, Mar 25, 2009 at 5:30 AM, Gautham R Shenoy <ego@in.ibm.com> wrote:
> Commit-ID:  b7bb4c9bb01941fe8feb653f3410e7ed0c9bb786
> Gitweb:     http://git.kernel.org/tip/b7bb4c9bb01941fe8feb653f3410e7ed0c9bb786
> Author:     Gautham R Shenoy <ego@in.ibm.com>
> AuthorDate: Wed, 25 Mar 2009 14:44:27 +0530
> Committer:  Ingo Molnar <mingo@elte.hu>
> CommitDate: Wed, 25 Mar 2009 13:28:30 +0100
>
> sched: Add comments to find_busiest_group() function
>
> Impact: cleanup
>
> Add /** style comments around find_busiest_group(). Also add a few
> explanatory comments.

...but there are actual code changes. Hard to know if you intended to
do that and forgot to changelog it, or if it's an unexpected hunk that
accidentally got included:

>        if (balance && !(*balance))
>                goto ret;
>
> -       if (!sds.busiest || sds.this_load >= sds.max_load
> -               || sds.busiest_nr_running == 0)
> +       if (!sds.busiest || sds.busiest_nr_running == 0)
> +               goto out_balanced;
> +
> +       if (sds.this_load >= sds.max_load)
>                goto out_balanced;
>
>        sds.avg_load = (SCHED_LOAD_SCALE * sds.total_load) / sds.total_pwr;
>
> -       if (sds.this_load >= sds.avg_load ||
> -                       100*sds.max_load <= sd->imbalance_pct * sds.this_load)
> +       if (sds.this_load >= sds.avg_load)
> +               goto out_balanced;
> +
> +       if (100 * sds.max_load <= sd->imbalance_pct * sds.this_load)
>                goto out_balanced;
>
>        sds.busiest_load_per_task /= sds.busiest_nr_running;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2009-03-25 17:07    [W:0.125 / U:0.440 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site