lkml.org 
[lkml]   [2009]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 05/13] [s390] changed ioctls to unlocked
On Tue, 24 Mar 2009 16:12:40 -0500
stoyboyker@gmail.com wrote:

> From: Stoyan Gaydarov <stoyboyker@gmail.com>
>
> Signed-off-by: Stoyan Gaydarov <stoyboyker@gmail.com>
> ---
> drivers/s390/char/tape_char.c | 47 +++++++++++++++++++++++----------
> drivers/s390/char/vmwatchdog.c | 57 ++++++++++++++++++++++++++--------------
> 2 files changed, 70 insertions(+), 34 deletions(-)

Please resend with the comments that Jonathan made for your other
patches: first define variables then lock_kernel() and also please use
gotos.

Thanks!


\
 
 \ /
  Last update: 2009-03-25 13:01    [W:0.130 / U:0.740 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site