Messages in this thread | | | Date | Tue, 24 Mar 2009 22:31:25 -0400 | Subject | Re: [PATCH 04/13] [blackfin] changed ioctls to unlocked | From | Mike Frysinger <> |
| |
On Tue, Mar 24, 2009 at 17:12, <stoyboyker@gmail.com> wrote: > --- a/arch/blackfin/mach-bf561/coreb.c > +++ b/arch/blackfin/mach-bf561/coreb.c > @@ -220,9 +220,10 @@ static int coreb_release(struct inode *inode, struct file *file) > return 0; > } > > -static int coreb_ioctl(struct inode *inode, struct file *file, > - unsigned int cmd, unsigned long arg) > +static long coreb_ioctl(struct file *file, unsigned int cmd, unsigned long arg) > { > + lock_kernel(); > + > int retval = 0; > int coreb_index = 0; > > @@ -289,6 +290,7 @@ static int coreb_ioctl(struct inode *inode, struct file *file, > #endif > } > > + unlock_kernel(); > return retval; > }
there is no need to lock the kernel in here. people have asked in the past and we've told them that it's pointless. simply change it to use unlocked_ioctl. -mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |