Messages in this thread | | | Date | Wed, 25 Mar 2009 08:24:59 +0800 | From | Herbert Xu <> | Subject | Re: Revert "gro: Fix legacy path napi_complete crash", |
| |
On Tue, Mar 24, 2009 at 03:47:43PM -0700, David Miller wrote: > > > I think the problem is that we need to do the GRO flush before the > > list delete and clearing the NAPI_STATE_SCHED bit. > > Ok Herbert, I'm even more sure of this because in your original commit > log message you mention: > > This simply doesn't work since we need to flush the held > GRO packets first.
That's only because I was calling __napi_complete, which is used by drivers in general so I added the check to ensure that GRO packets have been flushed. Now that we're open-coding it this is no longer a requirement.
But what's more GRO should be off on Ingo's test machines because we haven't added anything to turn it on by default for non-NAPI drivers.
Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| |