lkml.org 
[lkml]   [2009]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 1/3] x86: fix set_extra_move_desc calling


    Impact: fix bug with desc moving when logical flat

    Eric pointed out that should compare with old desc.
    acctually this bug is introduced by:
    | commit 22f65d31b25a320a5246592160bcb102d2791c45
    |
    | Author: Mike Travis <travis@sgi.com>
    | Date: Tue Dec 16 17:33:56 2008 -0800
    |
    | x86: Update io_apic.c to use new cpumask API
    |
    | Impact: cleanup, consolidate patches, use new API

    so need to move that before...

    ---
    arch/x86/kernel/apic/io_apic.c | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    Index: linux-2.6/arch/x86/kernel/apic/io_apic.c
    ===================================================================
    --- linux-2.6.orig/arch/x86/kernel/apic/io_apic.c
    +++ linux-2.6/arch/x86/kernel/apic/io_apic.c
    @@ -592,8 +592,9 @@ set_desc_affinity(struct irq_desc *desc,
    if (assign_irq_vector(irq, cfg, mask))
    return BAD_APICID;

    - cpumask_and(desc->affinity, cfg->domain, mask);
    + /* check that before desc->addinity get updated */
    set_extra_move_desc(desc, mask);
    + cpumask_and(desc->affinity, cfg->domain, mask);

    return apic->cpu_mask_to_apicid_and(desc->affinity, cpu_online_mask);
    }

    \
     
     \ /
      Last update: 2009-03-24 22:23    [W:0.022 / U:0.784 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site