Messages in this thread | | | Date | Tue, 24 Mar 2009 20:19:00 +0100 | From | Ingo Molnar <> | Subject | Re: Revert "gro: Fix legacy path napi_complete crash", (was: Re: Linux 2.6.29) |
| |
* Ingo Molnar <mingo@elte.hu> wrote:
> * Herbert Xu <herbert@gondor.apana.org.au> wrote: > > > On Tue, Mar 24, 2009 at 04:47:17PM +0100, Ingo Molnar wrote: > > > > > > test failure on one of the boxes, interface got stuck after ~100K > > > packets: > > > > > > eth1 Link encap:Ethernet HWaddr 00:13:D4:DC:41:12 > > > inet addr:10.0.1.13 Bcast:10.0.1.255 Mask:255.255.255.0 > > > inet6 addr: fe80::213:d4ff:fedc:4112/64 Scope:Link > > > UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1 > > > RX packets:22555 errors:0 dropped:0 overruns:0 frame:0 > > > TX packets:1897 errors:0 dropped:0 overruns:0 carrier:0 > > > collisions:0 txqueuelen:1000 > > > RX bytes:2435071 (2.3 MiB) TX bytes:503790 (491.9 KiB) > > > Interrupt:11 Base address:0x4000 > > > > What's the NIC and config on this one? If it's still using the > > legacy/netif_rx path, where GRO is off by default, this patch > > should make it exactly the same as with my original patch > > reverted. > > Same forcedeth box i reported before. Config below. (note: if you > want to use it you need to run it through 'make oldconfig', with > all defaults accepted)
Hm, i justhad a test failure (hung interface) with this too.
I'll go back to the original straight revert of "303c6a0: gro: Fix legacy path napi_complete crash", and will test it overnight - to establish a baseline of stability again. (to make sure there are no other bugs interacting)
Ingo
| |