Messages in this thread | | | Date | Tue, 24 Mar 2009 12:37:01 +0100 | From | Jens Axboe <> | Subject | Re: [PATCH 15/17] block: kill end_request() |
| |
On Sat, Mar 21 2009, Tejun Heo wrote: > Tejun Heo wrote: > > Impact: kill obsolete interface function > > > > end_request() has been kept around for backward compatibility; > > however, it seems to be about time for it to go away. > > > > * There aren't too many users left. > > > > * Its use of @updtodate is pretty confusing. > > > > * In some cases, newer code ends up using mixture of end_request() and > > [__]blk_end_request[_all](), which is way too confusing. > > > > So, kill it. > > > > Most conversions are straightforward. Noteworthy ones are... > > > > * paride/pcd: next_request() updated to take 0/-errno instead of 1/0. > > > > * paride/pf: pf_end_request() and next_request() updated to take > > 0/-errno instead of 1/0. > > > > * xd: xd_readwrite() updated to return 0/-errno instead of 1/0. > > > > * mtd/mtd_blkdevs: blktrans_discard_request() updated to return > > 0/-errno instead of 1/0. Unnecessary local variable res > > initialization removed from mtd_blktrans_thread(). > > This patch isn't correct. Will post updated version later.
The patchset is no longer in the for-2.6.30 upstream branch of the block git repo, due to the this glitch and the debate on ide conflicts (which I still find extremely silly and an over reaction).
I trust you will resend it when you are ready!
-- Jens Axboe
| |