lkml.org 
[lkml]   [2009]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Block - Honour barrier requests in loop driver
On Tue, Mar 24 2009, Jens Axboe wrote:
> On Tue, Mar 24 2009, Nikanth Karthikesan wrote:
> > On Wednesday 18 March 2009 10:28:20 Nikanth Karthikesan wrote:
> > > On Wednesday 18 March 2009 00:39:05 Christoph Hellwig wrote:
> > > > On Tue, Mar 17, 2009 at 05:39:49PM +0530, Nikanth Karthikesan wrote:
> > > > > + if (!file->f_op || !file->f_op->fsync) {
> > > > > + ret = -EOPNOTSUPP;
> > > > > + goto out;
> > > > > + }
> > > >
> > > > file->f_op is never zero, so you can remove the checks for that.
> > > > Otherwise looks good.
> > >
> > > Thanks for reviewing. I've removed that check.
> > >
> > > Jens, Can you merge this?
> > >
> > Hi Jens
> >
> > Did you get to look at this? Can you merge this?
>
> Yep, I'll merge it. Thanks!

Patch is line wrapped, and you still have one more check for f->f_op ==
NULL that you don't need. I have fixed it up, but please fix your
mailer.

--
Jens Axboe



\
 
 \ /
  Last update: 2009-03-24 12:29    [from the cache]
©2003-2011 Jasper Spaans