Messages in this thread | | | Date | Tue, 24 Mar 2009 12:24:43 +0100 | From | Jens Axboe <> | Subject | Re: [PATCH] Block - Honour barrier requests in loop driver |
| |
On Tue, Mar 24 2009, Nikanth Karthikesan wrote: > On Wednesday 18 March 2009 10:28:20 Nikanth Karthikesan wrote: > > On Wednesday 18 March 2009 00:39:05 Christoph Hellwig wrote: > > > On Tue, Mar 17, 2009 at 05:39:49PM +0530, Nikanth Karthikesan wrote: > > > > + if (!file->f_op || !file->f_op->fsync) { > > > > + ret = -EOPNOTSUPP; > > > > + goto out; > > > > + } > > > > > > file->f_op is never zero, so you can remove the checks for that. > > > Otherwise looks good. > > > > Thanks for reviewing. I've removed that check. > > > > Jens, Can you merge this? > > > Hi Jens > > Did you get to look at this? Can you merge this?
Yep, I'll merge it. Thanks!
-- Jens Axboe
| |