lkml.org 
[lkml]   [2009]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 07/12] DRBD: main
On Mon, Mar 23, 2009 at 04:48:02PM +0100, Philipp Reisner wrote:
> +#if CONFIG_PROC_FS
> + /*
> + * register with procfs
> + */
> + drbd_proc = create_proc_entry("drbd", S_IFREG | S_IRUGO , NULL);
> +
> + if (!drbd_proc) {
> + printk(KERN_ERR "drbd: unable to register proc file\n");
> + goto Enomem;
> + }
> +
> + drbd_proc->proc_fops = &drbd_proc_fops;

Use proc_create().

> + drbd_proc->owner = THIS_MODULE;

Unnecessary now.

> +#else
> +# error "Currently drbd depends on the proc file system (CONFIG_PROC_FS)"
> +#endif

You should "depends on PROC_FS" then and remove this #error.
#ifdef would also become unnecessary.


\
 
 \ /
  Last update: 2009-03-23 17:47    [W:0.105 / U:1.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site