Messages in this thread | | | Date | Mon, 23 Mar 2009 08:58:42 -0700 | From | Greg KH <> | Subject | Re: [PATCH 01/12] DRBD: lru_cache |
| |
On Mon, Mar 23, 2009 at 04:47:56PM +0100, Philipp Reisner wrote: > The lru_cache is a fixed size cache of equal sized objects. It allows its > users to do arbitrary transactions in case an element in the cache needs to > be replaced. Its replacement policy is LRU.
You forgot to add a "Signed-off-by:" line to each patch :(
Also, a general description of what drbd is, and why we want it would be good to have.
> --- > diff -uNrp linux-2.6.29-rc8/drivers/block/drbd/lru_cache.h linux-2.6.29-rc8-drbd/drivers/block/drbd/lru_cache.h > --- linux-2.6.29-rc8/drivers/block/drbd/lru_cache.h 1970-01-01 01:00:00.000000000 +0100 > +++ linux-2.6.29-rc8-drbd/drivers/block/drbd/lru_cache.h 2009-03-23 11:25:50.991276000 +0100 > @@ -0,0 +1,118 @@ > +/* > +-*- linux-c -*-
I think you can delete these lines from all of your files.
thanks,
greg k-h
| |