lkml.org 
[lkml]   [2009]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/7] blktrace: various cleanups and fixes

On Fri, 20 Mar 2009, Ingo Molnar wrote:

>
> * Ingo Molnar <mingo@elte.hu> wrote:
>
> >
> > * Li Zefan <lizf@cn.fujitsu.com> wrote:
> >
> > > While trying to use blktrace in -tip tree, I encounted kernel NULL
> > > dereference, so I looked into the code, and then found some other
> > > bugs.
> > >
> > > This patchset is part 1, and I have some other pending fixes.
> > >
> > > Each patch is small and straightforward, and should be easy to review:
> > >
> > > [PATCH 1/7] blktrace: fix possible memory leak
> > > [PATCH 2/7] blktrace: make blk_tracer_enabled a bool flag
> > > [PATCH 3/7] blktrace: remove blk_probe_mutex
> > > [PATCH 4/7] blktrace: don't increase blk_probes_ref if failed to setup blk trace
> > > [PATCH 5/7] blktrace: report EBUSY correctly
> > > [PATCH 6/7] blktrace: remove sysfs_blk_trace_enable_show/store()
> > > [PATCH 7/7] blktrace: avoid accessing NULL bdev->bd_disk
> > > ---
> > > blktrace.c | 154 +++++++++++++++++--------------------------------------------
> > > 1 file changed, 45 insertions(+), 109 deletions(-)
> > >
> > > Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
> >
> > Nice fixes. Applied to tip:tracing/blktrace, thanks!
>
> Which would go upstream in the .30 merge window (unless Jens or
> Steve objects of course).

I didn't see anything wrong with these patches. (sorry for the late reply,
I'm still going through emails).

Acked-by: Steven Rostedt <srostedt@redhat.com>

-- Steve



\
 
 \ /
  Last update: 2009-03-23 15:51    [W:0.057 / U:9.888 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site