Messages in this thread | | | Date | Sun, 22 Mar 2009 15:30:19 +0100 | From | Pierre Ossman <> | Subject | Re: [PATCH 8/10] OMAP: HSMMC: Make driver support dynamic idle |
| |
On Thu, 12 Mar 2009 18:23:46 +0200 Adrian Hunter <adrian.hunter@nokia.com> wrote:
> From 47b6de0fcfeb5948199dbed941847580bedc5315 Mon Sep 17 00:00:00 2001 > From: Amit Kucheria <amit.kucheria@verdurent.com> > Date: Thu, 12 Mar 2009 15:47:39 +0200 > Subject: [PATCH] OMAP: HSMMC: Make driver support dynamic idle > > Add a timer that is kept active by MMC requests. FCLK is disabled on > timeout. > > Signed-off-by: Amit Kucheria <amit.kucheria@verdurent.com> > Signed-off-by: Jarkko Lavinen <jarkko.lavinen@nokia.com> > Signed-off-by: Adrian Hunter <adrian.hunter@nokia.com> > ---
NAK. This should be implemented in the core where we get a consistent behaviour across all hosts. The principle with a timeout is sound though.
As for the current state of the driver, stop fiddling with the clock when it isn't necessary.
Rgds -- -- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org rdesktop, core developer http://www.rdesktop.org
WARNING: This correspondence is being monitored by the Swedish government. Make sure your server uses encryption for SMTP traffic and consider using PGP for end-to-end encryption.
| |